"Bert Huijben" <b...@qqmail.nl> writes: >> -----Original Message----- >> From: cmpil...@apache.org [mailto:cmpil...@apache.org] >> Sent: woensdag 9 februari 2011 18:07 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1068977 - in /subversion/trunk/subversion: >> svn/cat-cmd.c tests/cmdline/cat_tests.py >> >> Author: cmpilato >> Date: Wed Feb 9 17:07:19 2011 >> New Revision: 1068977 >> >> URL: http://svn.apache.org/viewvc?rev=1068977&view=rev >> Log: >> Fix issue #3713 ("svn cat for non-existing file returns incorrect >> exit-status"). Make 'svn cat' return a non-zero errorcode when one or >> more targets fails. Also print an error message in those situations. >> >> * subversion/svn/cat-cmd.c >> (svn_cl__cat): Pass SVN_ERR_FS_NOT_FOUND to svn_cl__try in order to >> catch this error when processing non existent URL targets, print >> warning and proceed with other targets. Print error message at the >> end if operation fails on any one of the targets and return 1. >> >> * subversion/tests/cmdline/cat_tests.py >> (cat_local_directory, cat_nonexistent_file, cat_skip_uncattable, >> cat_unversioned_file, cat_url_special_characters): >> Update return code and use regular expressions to match output. >> (cat_non_existing_remote_file): New test. >> (test_list): Add reference to new test. >> >> Patch by: Noorul Islam K M <noo...@collab.net> >> (Tweaked by me.) > > FAIL: cat_tests.py 1: cat a local directory > FAIL: cat_tests.py 4: cat a nonexistent file > FAIL: cat_tests.py 5: cat should skip uncattable resources > FAIL: cat_tests.py 6: cat an unversioned file parent dir thinks exists > > These tests fail on all ra-layers and there are a few more errors on the > layers that have authorization support. > > > Noorul, can you run at least the ra_local tests before sending a patch? >
I ran 'make check' and it did not complain. Doesn't that cover ra_local? Thanks and Regards Noorul > (It would be nicer if you could test all relevant ra layers, but that is a > bit too much to ask) > > Bert
