Johan Corveleyn wrote on Fri, Feb 04, 2011 at 13:20:29 +0100: > On Fri, Feb 4, 2011 at 7:56 AM, Daniel Shahaf <d...@daniel.shahaf.name> wrote: > > Could you have a look? (attached) > > Nice. It looks good to me (haven't tested it, just looked at the code; > I assume it passes with trunk?) >
Thanks, yes, r1068749. While I'm here, in light of the truncation bug in diff3 earlier today, how about adding a warning to svn_diff_diff4_2() family of API's to the effect of "@warning This code is experimental"? > The order of the parameters is correct: tools/diff/diff4.c does > exactly the same thing (switch the first and second argument), before > it passes them to svn_diff_file_diff4.
