On Feb 4, 2011, at 6:57 AM, hwri...@apache.org wrote: > Author: hwright > Date: Fri Feb 4 14:57:14 2011 > New Revision: 1067186 > > URL: http://svn.apache.org/viewvc?rev=1067186&view=rev > Log: > Introduce a new helper function which compares two checksums and then returns > the appropriate error. > > One reason for this is to consolidate and consistify the various strings used > in the error message (to help translators). Another is to remove (or at least > reduce) the occurance of the "format not a string literal, argument types not > checked" warnings generated by the old style of use. > > Subsequent commits will update other uses and make the error message > generation > a tad more flexible. > > * subversion/libsvn_subr/checksum.c > (svn_checksum_mismatch_err): New. > > * subversion/include/svn_checksum.h > (svn_checksum_mismatch_err): New.
What do you think about naming it svn_checksum_assert_equal or _equals? That way people probably won't need to wonder what the function does. Blair
