On 04.02.2011 09:08, Neil Bird wrote:
Around about 03/02/11 17:01, Stefan Sperling typed ...
* subversion/libsvn_subr/io.c
svn_io_open_unique_file3: don't call svn_io_open_uniquely_named(),
but instead use a copy of that routine
Which routine, precisely?
svn_io_open_uniquely_named(); sorry, I thought that was clear enough.
I had a similar patch in place on the performance branch.
Due to changes in the calling functions, the extra randomization
has now become unnecessary.
Have you taken a look at the implementation of
svn_io_open_unique_file3()
in Subversion's trunk code?
Yes, and in fact that was what I initially tried, but (with
admittedly little effort) it wouldn't compile for several reasons that
seemed to be down to other API changes that weren't in 1.6.x (apr ones
IIRC).
I'll give it another bash, though , if you think it's worth it.
Definitely. It contains quite a number of file access
optimizations that should become best visible on
"high overhead" FS like NTFS.
-- Stefan^2.
