Re: svn commit: r1064138 - in /subversion/branches/uris-as-urls: ./ subversion/include/ subversion/libsvn_client/ subversion/libsvn_subr/ subversion/svn/ subversion/tests/libsvn_subr/

[C. Michael Pilato]

On 01/27/2011 11:16 AM, C. Michael Pilato wrote:
> On 01/27/2011 09:56 AM, Bert Huijben wrote:
>>> Modified: subversion/branches/uris-as-
>>> urls/subversion/libsvn_client/locking_commands.c
> 
> [...]
> 
>>> @@ -206,9 +206,16 @@ organize_lock_targets(const char **commo
>>>      {
>>>        const char *parent, *base;
>>>        if (url_mode)
>>> -        svn_url_split(&parent, &base, *common_parent_url,
>>> result_pool);
>>> +        {
>>> +          svn_url_split(&parent, &base, *common_parent_url,
>>> +                        result_pool);
>>> +          svn_path_uri_encode(base, result_pool);
>>
>> I think you tried to store the result in base?
>>
>> Or should the encode be removed?
> 
> Encode can't be removed just yet -- I'll tackle that in a subsequent pass.
> But yes, I definitely should have kept the returned value!

Fixed this in r1064179.

-- 
C. Michael Pilato <cmpil...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

signature.asc
Description: OpenPGP digital signature