s...@apache.org wrote on Wed, Jan 12, 2011 at 20:36:34 -0000: > Author: stsp > Date: Wed Jan 12 20:36:33 2011 > New Revision: 1058308 > > URL: http://svn.apache.org/viewvc?rev=1058308&view=rev > Log: > * publish/docs/release-notes/1.7.html > (atomic-revprops): Mention that this is also a client-side fix (suggested by > danielsh). Provide a link to the pre-revprop-change hook script by > philip which fixes the issue #3546 race even for pre-1.7 svnsync clients. >
Two comments: * The entire locking discussion applies unmodified to svnrdump, since it shares the locking logic with svnsync: namely, 'svnrdump load' is susceptible to the same race condition with ≤1.6 servers. That logic is now svn_ra__get_operational_lock(). (Its docstring doesn't currently mention the race condition with old servers; I'll get to it.) * The difference that's supposed to cause Philip's script to work as advertised is that svn_repos_fs_change_rev_prop4() uses the same propvalue to compute the ACTION parameter and to pass as the "old propvalue" to the FS for atomicity. I'm too sleepy right now to determine whether Philip's script will actually work as advertised given this server-side change, so just throwing it out there for now. > Modified: > subversion/site/publish/docs/release-notes/1.7.html > > Modified: subversion/site/publish/docs/release-notes/1.7.html > URL: > http://svn.apache.org/viewvc/subversion/site/publish/docs/release-notes/1.7.html?rev=1058308&r1=1058307&r2=1058308&view=diff > ============================================================================== > --- subversion/site/publish/docs/release-notes/1.7.html (original) > +++ subversion/site/publish/docs/release-notes/1.7.html Wed Jan 12 20:36:33 > 2011 > @@ -551,16 +551,21 @@ a more useful error message on temporary > </div> <!-- http-redirects --> > > <div class="h3" id="atomic-revprops"> > -<h3>Atomic revprop changes (<em>server</em>) > +<h3>Atomic revprop changes (<em>client</em> and <em>server</em>) > <a class="sectionlink" href="#atomic-revprops" > title="Link to this section">¶</a> > </h3> > > -<p>Revprop changes are now handled atomically on the server. > +<p>Revprop changes are now handled atomically. > This fixes a known race condition in the locking algorithm used by > <code>svnsync</code> (see <a > href="http://subversion.tigris.org/issues/show_bug.cgi?id=3546"; > - >issue #3546</a>.)</p> > + >issue #3546</a>.).</p> > +<p>With a 1.7 server, it is possible to fix the svnsync race condition > +even for pre-1.7 svnsync clients by installing the pre-revprop-change hook > +script given in > +<a href="http://subversion.tigris.org/issues/show_bug.cgi?id=3546#desc12"; > + >comment 12 of issue #3546</a>.</p> > > </div> <!-- atomic-revprops --> > > >
