On 01/05/2011 09:37 AM, C. Michael Pilato wrote: > On 01/05/2011 06:42 AM, Prabhu Gnana Sundar wrote: >> Hi all, >> >> Currently svnadmin, svnlook, svnsync, svndumpfilter, svnversion, >> svnserve show the entire version information even if '--version --quiet' >> is given as command. >> >> The '--quiet' option has *not* been handled so far. >> >> This patch would make svnadmin, svnlook, svnsync, svndumpfilter, >> svnversion, svnserve '--version --quiet' to display *only* the version >> number(info) just like 'svn --version --quiet' does. > > Mmm... consistency. Consistency makes me smile. > >> I have attached the patch and the log message with this mail. Please >> give your views on this. > > I have reviewed this patch and will commit it shortly (after some testing).
Committed in r1055478. Thanks! >> Index: subversion/svnlook/main.c >> =================================================================== >> --- subversion/svnlook/main.c (revision 1055432) >> +++ subversion/svnlook/main.c (working copy) >> @@ -176,6 +176,9 @@ >> " " >> " Ignore changes in EOL style")}, >> >> + {"quiet", 'q', 0, >> + N_("no progress (only errors) to stderr")}, >> + > > There are some code formatting/indentation inconsistencies here which didn't > originate with your change, but which your change extends. And fixed these other indentation issues in r1055481. -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature