On Mon, 2010-11-22, cmpil...@apache.org wrote:
> Issue #3693 - Multi-target update output is quite confusing.
> 
> Add notifications at the start of each performed update, and a summary
> at the end of the whole mess.

Hi Mike.  I like the direction of this.

Sometimes the summary prints the abspath instead of the relpath
specified on the command line.  Specifically, this happens if you
specify a changelist.  However, the "Updating..." line manages to print
the relpath.  In the following transcript, the debug marked (1) shows
targets[0] near the start of svn_cl__update(), and (2) shows that
targets[0] has been converted to an abspath after changelist processing.

[[[
$ ~/src/subversion-c/subversion/tests/cmdline/changelist_tests.py
--bin=/home/julianfoad/src/subversion-c/bin 8
PASS:  changelist_tests.py 8: update --changelist

julianf...@edith ~/src/subversion-c/obj-dir/subversion/tests/cmdline
$ svn up -r1 svn-test-work/working_copies/changelist_tests-8/A/muDBG:
update-cmd.c:  95: (1)
'svn-test-work/working_copies/changelist_tests-8/A/mu'
DBG: update-cmd.c: 133: (2)
'svn-test-work/working_copies/changelist_tests-8/A/mu'
Updating 'svn-test-work/working_copies/changelist_tests-8/A/mu' ...
U    svn-test-work/working_copies/changelist_tests-8/A/mu
Updated to revision 1.

julianf...@edith ~/src/subversion-c/obj-dir/subversion/tests/cmdline
$ svn up --cl u svn-test-work/working_copies/changelist_tests-8/DBG:
update-cmd.c:  95: (1) 'svn-test-work/working_copies/changelist_tests-8'
DBG: update-cmd.c: 133: (2)
'/home/julianfoad/build/subversion-c/subversion/tests/cmdline/svn-test-work/working_copies/changelist_tests-8/A/mu'
Updating 'svn-test-work/working_copies/changelist_tests-8/A/mu' ...
U    svn-test-work/working_copies/changelist_tests-8/A/mu
Updated to revision 2.
Updating 'svn-test-work/working_copies/changelist_tests-8/A/D/G/tau' ...
Updated to revision 2.
Summary of updates:
  Updated
'/home/julianfoad/build/subversion-c/subversion/tests/cmdline/svn-test-work/working_copies/changelist_tests-8/A/mu'
 to r2.
  Updated
'/home/julianfoad/build/subversion-c/subversion/tests/cmdline/svn-test-work/working_copies/changelist_tests-8/A/D/G/tau'
 to r2.
]]]

- Julian


Reply via email to