Hi,

I found a small problem in svn_client_delete4() when passing multiple urls to delete.

If at least one of the urls contain escaped chars, then the deletion fails. The reason is in libsvn_client/delete.c, line 209:
      item_url = svn_path_url_add_component2(common, path, subpool);

that line combines the common root of all delete targets with the relative path of each of the targets, but it escapes those again.

I thought that the svn API requires all urls passed to it to be already escaped - this at least is required if only one single target is passed to the API. Only if multiple targets are passed, then those get escaped again.

The problem isn't just on trunk but also in 1.6.x.

Does this mean that for multiple targets clients must not escape the urls? Not sure if this is a bug, but it's at least an inconsistency in the API.

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

Reply via email to