Hi Philip,
Philip Martin wrote:
style...@apache.org writes:
Author: stylesen
Date: Wed Oct 6 14:41:35 2010
New Revision: 1005065
+static svn_boolean_t
+password_get_gpg_agent(const char **password,
+ apr_hash_t *creds,
+ const char *realmstring,
+ const char *username,
+ apr_hash_t *parameters,
+ svn_boolean_t non_interactive,
+ apr_pool_t *pool)
+{
+ int sd;
+ char *gpg_agent_info = NULL;
+ char *value;
+ char *p = NULL;
+ char *ep = NULL;
+ char *buffer;
+
+ apr_array_header_t *socket_details;
+ char *request = NULL;
+ const char *cache_id = NULL;
+ struct sockaddr_un addr;
+ int recvd;
+ char *tty_name;
+ char *tty_type;
+ const char *socket_name = NULL;
+ svn_checksum_t *digest = NULL;
+
+ value = getenv( "GPG_AGENT_INFO");
+
+ if (value != NULL)
+ {
+ gpg_agent_info = apr_pstrmemdup(pool, value, strlen(value));
+ socket_details = svn_cstring_split(gpg_agent_info, ":", TRUE, pool);
No need to apr_pstrmemdup if passing to svn_cstring_split.
I ve incorporated many of the changes you mentioned, in r1005780, except for
the apr sockets and config file stuff thingy which I shall work on later.
Once again, thanks for the review :)
--
Senthil Kumaran S
http://www.stylesen.org/
