On Fri, Sep 24, 2010 at 10:26, Philip Martin <philip.mar...@wandisco.com> wrote: > Greg Stein <gst...@gmail.com> writes: > >> Step back and look at that code. >> >> The gather_children() got a bit more complicated because I was trying >> to get the list of children from BASE_NODE and WORKING_NODE, and union >> those together (or skip the union altogether in certain cases). With >> NODES, it becomes one simple query: >> >> SELECT DISTINCT local_relpath FROM nodes >> WHERE wc_id = ?1 AND parent_relpath = ?2; >> >> Done. >> >> Pass that query to single_table_children() and return. >> >> count_children, add_children_to_hash, and union_children can all be >> eliminated with SVN_WC__NODES_ONLY. > > Yes, but in the short term NODES is going to look like BASE/WORKING.
That's fine, but not for gather_children() when !base_only. By definition, it is blending BASE and WORKING children, and that is exactly what NODES does for you already. >... Cheers, -g
