Greg Stein <gst...@gmail.com> writes: > On Thu, Sep 23, 2010 at 11:22, <julianf...@apache.org> wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Thu Sep 23 15:22:52 2010 >>... >> @@ -3665,7 +3665,7 @@ svn_wc__db_op_copy(svn_wc__db_t *db, >> SVN_ERR(svn_sqlite__bindf(stmt, "issisnnnt", >> src_pdh->wcroot->wc_id, src_relpath, >> dst_relpath, >> - (children == NULL) ? (apr_int64_t)2 : >> + (children == NULL) ? (apr_int64_t)2 : /* ### op_depth >> */ >> (apr_int64_t)1, /* no directory or stub */ > > I see stuff like this scattered all through wc_db. How can we possibly > use constants for op_depth? Those constants only make sense in > multi-db. Shouldn't these be switched to look at the path now?
op_depth is not implemented yet beyond zero/non-zero. We could change all those lines to a simple (apr_int64_t)1. There is one advantage to making some of them 1 and some of them 2: it means we can't accidentally rely on the value being 1. -- Philip
