artag...@apache.org wrote on Sat, Aug 07, 2010 at 12:31:50 -0000: > Author: artagnon > Date: Sat Aug 7 12:31:50 2010 > New Revision: 983222 > > URL: http://svn.apache.org/viewvc?rev=983222&view=rev > Log: > svnrdump: Fix a bug in the load_editor; it was unable to handle > revisions without node information previously. > > * subversion/svnrdump/load_editor.c > (close_revision): Add a new if-branch; if the commit_editor doesn't > exist, create one, open_root and close_edit on it to indicate that > we've finished processing the revision. While at it, also fix indentation. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I take it you haven't seen my previous commit review yet? > > Modified: > subversion/trunk/subversion/svnrdump/load_editor.c > > Modified: subversion/trunk/subversion/svnrdump/load_editor.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/svnrdump/load_editor.c?rev=983222&r1=983221&r2=983222&view=diff > ============================================================================== > --- subversion/trunk/subversion/svnrdump/load_editor.c (original) > +++ subversion/trunk/subversion/svnrdump/load_editor.c Sat Aug 7 12:31:50 > 2010 > @@ -434,26 +434,43 @@ close_revision(void *baton) > - else { > - /* Close all pending open directories, and then close the edit > - session itself */ > - while (rb->db && rb->db->parent) > - { > - LDR_DBG(("Closing dir %p\n", rb->db->baton)); > - SVN_ERR(commit_editor->close_directory(rb->db->baton, rb->pool)); > - rb->db = rb->db->parent; > - } > - LDR_DBG(("Closing edit on %p\n", commit_edit_baton)); > - SVN_ERR(commit_editor->close_edit(commit_edit_baton, rb->pool)); > - } > + else if (commit_editor) > + { > + /* Close all pending open directories, and then close the edit > + session itself */ > + while (rb->db && rb->db->parent) > + { > + LDR_DBG(("Closing dir %p\n", rb->db->baton)); > + SVN_ERR(commit_editor->close_directory(rb->db->baton, rb->pool)); > + rb->db = rb->db->parent; > + } > + LDR_DBG(("Closing edit on %p\n", commit_edit_baton)); > + SVN_ERR(commit_editor->close_edit(commit_edit_baton, rb->pool)); > + }
