Hi Julian, Julian Foad writes: > On Thu, 2010-07-22, Ramkumar Ramachandra wrote: > > Jonathan Nieder writes: > [...] > > > > + /* Output name length, then name. */ > > > > + svn_stringbuf_appendcstr(*strbuf, > > > > + apr_psprintf(pool, "K > > > > %" APR_SSIZE_T_FMT "\n", > > > > + keylen)); > > > > + > > > > + svn_stringbuf_appendbytes(*strbuf, (const char > > > > *) key, keylen); > > > > > > Is the cast needed? (The answer might be "yes" if this code is meant > > > to be usable with C++ compilers.) > > > > These casts are all over in the source tree, so I'm guessing the > > answer is "yes". > > Actually no - Subversion C code is not intended to be compilable as C++ > and that cast is not needed. (Other casts that you see in Subversion > code are for different situations.)
Thanks for pointing that out. I'll fix them in my future commits. -- Ram
