On Wed, Jul 21, 2010 at 9:03 PM, Philip Martin <philip.mar...@wandisco.com> wrote: > hwri...@apache.org writes: > >> Author: hwright >> Date: Wed Jul 21 19:06:11 2010 >> New Revision: 966366 >> >> URL: http://svn.apache.org/viewvc?rev=966366&view=rev >> Log: >> Rev the client mkdir API to return commit info through the ctx callback. > >> +svn_error_t * >> +svn_client_mkdir3(svn_commit_info_t **commit_info_p, >> + const apr_array_header_t *paths, >> + svn_boolean_t make_parents, >> + const apr_hash_t *revprop_table, >> + svn_client_ctx_t *ctx, >> + apr_pool_t *pool) >> +{ >> + svn_client_ctx_t shadow_ctx; >> + struct capture_baton_t cb; >> >> + cb.info = commit_info_p; >> + cb.pool = pool; >> + cb.original_callback = ctx->commit_callback2; >> + cb.original_baton = ctx->commit_baton; >> + >> + shadow_ctx = *ctx; >> + shadow_ctx.commit_callback2 = capture_commit_info; >> + shadow_ctx.commit_baton = &cb; >> + >> + return svn_client_mkdir4(paths, make_parents, revprop_table, ctx, pool); >> +} > > subversion/libsvn_client/deprecated.c:123:20: warning: variable ‘shadow_ctx’ > set but not used > > I assume shadow_ctx should be passed to svn_client_mkdir4.
Correct. Fixed in r966429. -Hyrum
