On Thu, Jul 8, 2010 at 12:33, Julian Foad <julian.f...@wandisco.com> wrote: >... > The auto-upgrade code, currently used for 1.7-dev to 1.7-dev, is invoked > when opening a versioned directory: >... > So a possible way is: > > * bump_to_19() needs to migrate the contents of the SDB (and pristine > store) down into the WC-root SDB, and delete the SDB (and pristine > store), or do nothing if it is the WC-root SDB. > > * svn_wc__db_pdh_create_wcroot() needs to return not a new wcroot_t > object but a pointer to the existing one for the real WC-root, except of > course when it is creating the real WC-root object. > > * And in which function will we search for and find the WC root > directory? I can't see us using any of the existing functions such as > svn_wc__db_is_wcroot(), svn_wc__strictly_is_wc_root(), because they all > invoke svn_wc__db_pdh_parse_local_abspath().
I suspect that it might be too messy to have the auto-upgrade code manage this process. It finds an SDB, auto-upgrades, but then has to find one again? Much of the flow would be bastardized to handle this case. I'd suggest that we simply force it to be a manual upgrade. Cheers, -g
