On Thu, Jul 08, 2010 at 02:08:15PM +0200, Stefan Sperling wrote: > On Thu, Jul 08, 2010 at 12:39:22PM +0100, Julian Foad wrote: > > I've only skimmed through it so far, and probably can't do a full review > > before the end of the month. However from what I've seen it looks good > > enough to go ahead and then improve/fix later. > > OK, I'll fix up the bits above and commit.
FYI, on IRC, we decided to go for a different approach: <stsp> julianf, look at svn_hunk_t in svn_diff.h <stsp> the streams in there need special handling when reading lines from them <stsp> instead of overloading readline we can simply add a set of helper functions that are meant to be used for reading lines from those streams <stsp> that is specific to what we need in svn patch, <stsp> and avoids having to worry about all the other generic streams <stsp> and if a user calls the diff-specific stream reader functions on a generic stream, that's the user's problem <julianf> Yes, that sounds better. <stsp> ok, I'll do that then
