Re: svn commit: r941094 - /subversion/trunk/subversion/libsvn_client/commit_util.c

[Neels J Hofmeyr]

On 05/05/2010 10:45 AM, Philip Martin wrote:
> ne...@apache.org writes:
> 
>> Author: neels
>> Date: Tue May  4 23:31:42 2010
>> New Revision: 941094
>> URL: http://svn.apache.org/viewvc?rev=941094&view=rev
>> Log:
>> One less use of entry_t.
> 
>>    if (is_added)
>>      {
>> -      SVN_ERR(svn_wc__node_get_copyfrom_info(&entry_copyfrom_url,
>> -                                             &entry_copyfrom_rev,
>> +      svn_boolean_t is_copy_target;
>> +      const char *copyfrom_url;
>> +      svn_revnum_t copyfrom_rev;
>> +
>> +      SVN_ERR(svn_wc__node_get_copyfrom_info(&copyfrom_url,
>> +                                             &copyfrom_rev,
>>                                               &is_copy_target,
>>                                               ctx->wc_ctx, local_abspath,
>>                                               scratch_pool, scratch_pool));
> 
> ../src/subversion/libsvn_client/commit_util.c:565: warning: declaration of 
> ‘copyfrom_url’ shadows a parameter
> ../src/subversion/libsvn_client/commit_util.c:367: warning: shadowed 
> declaration is here

oops, thx!

I want to fix that whole duplicate-get_copyfrom_info thing anyway
(later/soon). That var shadowing shouldn't hurt for now, though, except for
the warning.

~Neels

signature.asc
Description: OpenPGP digital signature