On Fri, Apr 16, 2010 at 7:39 AM, Stefan Sperling <s...@elego.de> wrote:
> On Fri, Apr 16, 2010 at 11:38:41AM +0100, Philip Martin wrote: > > Julian Foad <julian.f...@wandisco.com> writes: > > > Just write "arr->nelts = 0;" (which is the entire body of > > > apr_array_clear()) and don't introduce an ifdef. > > I'm a bit sceptical. > Do we really want to rely on implementation details like > "arr->nelts = 0" in the APR code? We don't even do this in our own code. > > > I agree that we don't want #if like that in the main code. Put it in > > one of our private header files if you want to use it. > > I can make a private macro or function for this, sure. > This was causing some of the buildbots not to be able to build, so I went ahead and committed a fix in r934969. Feel free to review/update. -Hyrum
