Stefan Sperling wrote: > On Wed, Apr 14, 2010 at 03:48:49PM +0100, Julian Foad wrote: > > On Tue, 2010-04-13, s...@apache.org wrote: > > > (push_if_unique): New helper function, needed because we do not use > > > a hash table anymore to ensure path uniqueness. > > > > Why not use a hash table? It looks like doing so would have good > > effects - avoiding the need for push_if_unique() and the two sub-loops > > in check_dir_empty(). > > I've tried various approaches including hash tables. > I found the current way of doing it easy to write and follow.
OK... I just didn't see, during my quick read through, where a hash table would make things more difficult. - Julian > But I'm open to patches making it use hash tables instead, > if they help reduce the size of code related to deleting empty > directories. > > Stefan
