On 03/09/2010 02:41 PM, hwri...@apache.org wrote:
Author: hwright
Date: Tue Mar 9 22:41:16 2010
New Revision: 921181
URL: http://svn.apache.org/viewvc?rev=921181&view=rev
Log:
JavaHL: Fix a few header files to avoid a redundant declaration of SVN::Pool.
Instead of declaring the class (when it might also be declared previously by
some other header file), just include the header if needed. The header already
has the required #ifdef protection, and it doesn't cost much to parse it
again anyway.
Standard practice is to only include header files one needs for the
definition. Plus, it's not just that, but the cost of recompiling
everything that then #include's that header file if you touch Pooo.h
I suggest just reverse merging this change, as while it's not the cost
that matters (which is low as you state), but just being correct about it.
Regards,
Blair
