On Fri, 2010-03-05, Greg Stein wrote: > On Thu, Mar 4, 2010 at 13:15, <[email protected]> wrote: > > Author: julianfoad > > Date: Thu Mar 4 18:15:39 2010 > > New Revision: 919106 > > > > URL: http://svn.apache.org/viewvc?rev=919106&view=rev > > Log: > > Declare that two more WC functions always use absolute paths. > > > > * subversion/libsvn_wc/adm_files.h, > > subversion/libsvn_wc/adm_files.c > > (open_adm_file, svn_wc__open_writable_base): Rename path parameters to > > indicate they are always absolute paths. No code changes are necessary. > > (Each has only one caller and the caller already supplies absolute paths > > as input.) > > With only one caller, it may not be important, but we've also tended > to add assertions that the parameter is an absolute path. It is very > advisable for long-term APIs. I would expect both of these functions > to disappear, so it isn't that big of a deal, but I wanted to mention > the precedent.
Good plan. r920279. - Julian
