> -----Original Message----- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: woensdag 6 januari 2010 14:28 > To: 'Kamesh Jayachandran'; dev@subversion.apache.org > Subject: RE: [PATCH] Make svn clients indicate their operation name to > backend(right now only to DAV) > > > > > -----Original Message----- > > From: Kamesh Jayachandran [mailto:kam...@collab.net] > > Sent: woensdag 6 januari 2010 14:00 > > To: dev@subversion.apache.org > > Subject: [PATCH] Make svn clients indicate their operation name to > > backend(right now only to DAV) > > > > Hi All, > > > > This patch is with respect to the original thread > > > > http://mail-archives.apache.org/mod_mbox/subversion- > > dev/201001.mbox/browser > > > > Once this patch gets committed I can commit the mod_dav_svn change to > > handle the original commit via outdated proxy issue. > > > > This Patch revs the following public APIs, > > > > 'svn_client_uuid_from_url', 'svn_client_open_ra_session' and > > 'svn_ra_open3'. > > I have a few high level questions about this patch: > > Why do you rev svn_client_uuid_from_url? > > I would think that that function is a high level API, so it would be an > operation by itself. > > (looking at svn_client.h) What should I put in there as client that just > needs the uuid or verify that the repository exists? > > "checking-uuid-for-visualization-to-my-great-users"? > > I don't think we should rev the svn_client_ API for this specific change > here; especially since older clients will not pass anything anyway. > libsvn_client should fill that high level operation for library users or the > value is of no use on the server. > > And it should never be forwarded to master servers as the uuid is supposed > to be constant per repository. > > (BTW. the api is new in 1.7, so it needs no revving at all)
Forget this last sentence, it was not new. It was there since before 1.0 Bert