Kannan <kann...@collab.net> writes: > Make `--set-depth (empty|files|immediates) DIR' work, where DIR's depth > had already been set as `exclude'. Only `infinity' works as of now. > > * subversion/libsvn_wc/crop.c > (svn_wc_crop_tree2): Check the 'base status' of the node here and > remove the check done using `svn_wc__db_node_hidden()' as it > marks a node as 'hidden' if status is set as > `svn_wc__db_status_excluded'. > > * update_editor.c > (complete_directory): Call `svn_wc__set_depth' with the requested > depth rather than `infinity' by default. > > * entries.c > (svn_wc__set_depth): Set the entry's depth to the requested one rather > than `infinity' by default if the depth is not `exclude'. > > * wc_db.c > (svn_wc__db_temp_op_dir_set_depth): Remove the code which sets the > depth as `infinity' if the depth is not `exclude'. > > Patch by: Kannan R <kann...@collab.net>
It looks plausible, but it would be much better if you included a regression test that exercised the new code. If you fix something like this without adding a test there is no guarantee that some future change won't break it. -- Philip
