Stefan Sperling wrote: > On Tue, Nov 24, 2009 at 04:15:38PM -0800, Blair Zajac wrote: > > s...@apache.org wrote: > > >Author: stsp > > >Date: Tue Nov 24 23:03:26 2009 > > >New Revision: 883916 > > > > > >URL: http://svn.apache.org/viewvc?rev=883916&view=rev > > >Log: > > >Replace use of sprintf() with snprintf() everywhere expect within > > >#ifdef WIN32 since I can't test that. > > >In all these cases, sprintf() was used correctly, but my compiler > > >doesn't know that and prints warnings anyway. > > > > Why not use apr_snprintf()? > > We could use it, yeah. I simply didn't know about it.
snprintf was introduced in the C'99 standard, so officially we shouldn't assume we can use it, and a quick grep indicates we didn't use it until now. But it's very likely that any non-C'99 systems that Subversion is built on (Microsoft's, for one) provide it anyway. - Julian