C. Michael Pilato wrote: > Greg Stein wrote: >> On Thu, Nov 19, 2009 at 15:17, <cmpil...@apache.org> wrote: >>> Author: cmpilato >>> Date: Thu Nov 19 20:17:05 2009 >>> New Revision: 882279 > > [...] > >>> @@ -565,6 +565,8 @@ >>> + (field.alias or field.name) >>> + ' by:\s+|\s+)([^\s(].*)') >>> m = in_field_re.match(line) >>> + if m is None: >>> + sys.stderr.write("Error matching: %s\n" % (line)) >>> user, real, email = Contributor.parse(m.group(2)) >>> if user == 'me': >>> user = log.committer >> How does this work? Looks like you dropped group #2 from the regex. > > Different regexp. m.group(2) refers to the regexp which is built from a > string just above the context of this latter hunk.
Oh, and we never use group(2) of the field_re regexp match anywhere. Only group(1). -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature