Stefan Sperling wrote on Wed, 18 Nov 2009 at 15:08 +0100: > On Wed, Nov 18, 2009 at 03:24:10PM +0200, Daniel Shahaf wrote: > > In this case, how about losing the "GROUP BY hunk" from the sort? i.e., > > > > BIG_LIST = [] > > for each hunk: > > for each candidate in hunk: > > compute a score for candidate > > BIG_LIST.append(candidate) > > # based on line offset, endifs, whatever > > > > sort BIG_LIST by score > > for each candidate in BIG_LIST: > > if candidate->hunk.state not in ['applied', 'rejected']: > > # try to apply candidate->hunk at candidate->offset > > What does to "try to apply" mean? >
Maybe it just means "set hunk.state to 'applied'"; I forgot what other checks (apart from the applied/rejected check) had to be done before we decided "Yes, I decided to apply the hunk at <this> candidate". > Stefan >