jnioche commented on PR #2207: URL: https://github.com/apache/stormcrawler/pull/2207#issuecomment-6057602159
Thanks @rzo1, all three addressed and your tests added as is. (a) The query now goes through `unescapePath`/`escapePath` on its own, and a change sets `hasChanged`. This is safe for the query because these only decode unreserved characters, uppercase escapes, and escape control/non-ASCII/`[]\|`; `&`, `=`, `+`, `?` and `%` are left alone. A side effect: the `%7E` written by `URLEncodedUtils.format` is now decoded to `~`, so the issue's example gives `t=~%21q` as originally expected. I updated that test. Note that this may change some URL keys for existing crawls. (b) Agreed, the new behaviour is better; your test is in. (c) The fragment is now appended on rebuild. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
