abhinav-phi commented on PR #2123: URL: https://github.com/apache/stormcrawler/pull/2123#issuecomment-5609287435
Thanks — both blockers from the second round are addressed in this push: 1. **Scheme parsing** (acd35f2b): allowedSchemes is now built per element with the same comma split ProtocolFactory uses, trimmed and lowercased with Locale.ROOT, falling back to http/https only when nothing parses. AbstractQueryingSpoutSchemeTest covers the shipped comma-separated string (http,https,file), an explicit comma value, the list form, whitespace tolerance and uppercase schemes — no more valid-HTTPS-as-ERROR. 2. **Status stream wiring** (0d955ce4): rejected rows are emitted as Status.ERROR on the status stream from nextTuple (no more unbounded re-query spin), the stream is declared in AbstractQueryingSpout and in SQLSpout (the only subclass overriding declareOutputFields; the OpenSearch/Solr/URLFrontier spouts inherit it), the OpenSearch/Solr archetype and SQL crawler.flux files connect spout to status with FIELDS grouping on url, and SpoutStatusStreamWiringTest asserts that edge at topology level. internals.adoc documents the wiring for existing topologies. mvn -pl core verify -DCI_ENV=true is green, plus external/sql verified. Please re-review when you get a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
