abhinav-phi commented on PR #2112: URL: https://github.com/apache/stormcrawler/pull/2112#issuecomment-5497939546
Thanks for the review @dpol1 — both points are addressed in 1c7b442b: **Skip scoped to sub-documents.** The bolts now skip empty entries only for URLs *other than* the one being parsed. The entry for the document itself is always emitted, even when a filter emptied it, so its status keeps being updated downstream — the corner case you describe is ruled out. Locked in by `testEmptiedParentDocumentIsStillEmitted` in both `SubDocumentsFilterTest` (core) and the tika `ParserBoltTest`. **Skips are no longer silent.** Each skip increments a `skipped_empty_documents` scoped counter (alongside the existing `tuple_success` metrics) and logs the skipped URL at debug level. **Release note for filter authors.** The repo has no in-tree changelog file, so the note lives in the ParseFilter section of `docs/src/main/asciidoc/internals.adoc` and in the PR description: sub-documents should set at least one of content, text or metadata to be emitted, and `getIfPresent(url)` / `getOrCreate(url)` are the recommended accessors going forward. All core + tika tests pass (426 core, 4 tika), and the checkstyle / google-java-format / RAT gates are green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
