dpol1 commented on PR #2050: URL: https://github.com/apache/stormcrawler/pull/2050#issuecomment-5268689846
Real gap, thanks - good regression test too. Couple of questions: 1. What happens with a temporary redirect? All 3xx end up as REDIRECTION, so a site doing a 302 during maintenance would get its doc deleted - and with the default schedule that delete re-fires daily. Should we limit this to 301/308 (via `fetch.statusCode` - though JSoup meta-refresh emits REDIRECTION with status 200), or make it opt-in via config for existing topologies? 2. Since the ERROR branch got restructured, could we also assert ERROR still emits exactly one delete and FETCHED none? And does `assertEquals(metadata, ...)` actually test anything? Metadata has no `equals()`, so it's comparing the object with itself - maybe assert on a key instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
