dpol1 opened a new issue, #1951:
URL: https://github.com/apache/stormcrawler/issues/1951
### What would you like to be improved?
Follow-up to #1935. `MultiProxyManager.getConfiguredProxy` linearly scans
the configured proxies on every metadata-override request, to reuse the
configured `SCProxy` instance for usage accounting. O(n) per override request.
Low priority. A miss is harmless (the metadata proxy is still used, just
as a throwaway instance), the override path is opt-in per URL, and
`getLeastUsed` already does a comparable per-request scan. This is cleanup, not
a measured bottleneck.
### How should we improve?
Build a lookup map in `configure()` keyed on a normalized proxy identity,
and replace the scan with a map lookup. Note that `ProxyUtils.isSameProxy` also
compares `username`/`password`, so the key must include credentials, or
otherwise disambiguate a same `protocol+host+port` with different auth. No
behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
