jnioche commented on PR #1906:
URL: https://github.com/apache/stormcrawler/pull/1906#issuecomment-4459940353

   > If you don't mind @jnioche , I finished your PR by reverting 90% of it. :) 
The main issue was in the AbstractProtocolTest the AfterAll stopJetty() method 
stopped the jetty server, but the variable remained initialized after the first 
subclass test finished (E.g.: HttpProtocolProxyConcurrencyTest). When the 
second subclass wanted to initialize the jetty as it was in the BeforeEach 
initJetty(), it checked the httpServer is already initialized (but it wasn't 
running) so skipped the reinitialization.
   
   thanks @sigee 
   
   apologies for the half baked PR, I was evaluating Mistral's vibe tool and 
thought I would try it on a simple PR. Meant to have a closer look at it but 
you beat me to it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to