rzo1 commented on code in PR #1612: URL: https://github.com/apache/stormcrawler/pull/1612#discussion_r2226285904
########## external/sql/src/main/java/org/apache/stormcrawler/sql/IndexerBolt.java: ########## Review Comment: The original intention of the issue was to replace direct String concat with parameter replacements and pre-build queries. The SQL strings could be prepared on init and just looked up (might open the was for a more sophisticated solution using a connection pool). Side note: One would need to sanitize table names, too, because they cannot be set as ? In a prepared statement, so might be good to add a simple check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
