Hi team, I've been working with the org.apache.stormcrawler.Metadata API and noticed an inconsistency in the method signatures that I'd like to discuss.
Currently, the API has: - String[] getValues(String key) - void setValues(String key, String[] values) - void addValues(String key, Collection<String> values) The getter and setter methods use String[] arrays, while addValues uses Collection<String>. This inconsistency could be confusing for developers using the API. I'd like to propose making this more consistent. A few options to consider: 1. *Change addValues to use String[]* - keeps consistency with existing getter/setter 2. *Change getter/setter to use Collection<String>* - more flexible, follows modern Java conventions 3. *Provide overloaded methods* - support both approaches for backward compatibility What are your thoughts on this? I'm happy to work on a patch once we agree on the preferred approach. Best regards, Sigee
