mvolikas commented on code in PR #1491:
URL:
https://github.com/apache/incubator-stormcrawler/pull/1491#discussion_r1986065935
##########
pom.xml:
##########
@@ -489,31 +489,31 @@ under the License.
<outputDirectory>${project.basedir}/rat</outputDirectory>
<excludes>
<exclude>**/*.ndjson</exclude>
-
<exclude>**/*.mapping</exclude>
-
<exclude>**/*.flux</exclude>
-
<exclude>**/*.txt</exclude>
-
<exclude>**/*.rss</exclude>
-
<exclude>**/*.tar.gz</exclude>
-
<exclude>**/README.md</exclude>
-
<exclude>**/target/**</exclude>
-
<exclude>**/warc.inputs</exclude>
-
<exclude>LICENSE</exclude>
-
<exclude>NOTICE</exclude>
-
<exclude>DISCLAIMER</exclude>
-
<exclude>CONTRIBUTING.md</exclude>
-
<exclude>RELEASING.md</exclude>
-
<exclude>THIRD-PARTY.properties</exclude>
-
<exclude>THIRD-PARTY.txt</exclude>
-
<exclude>.github/*.md</exclude>
-
<exclude>.mvn/*.config</exclude>
-
<exclude>.gitattributes</exclude>
-
<exclude>**/dependency-reduced-pom.xml</exclude>
-
<exclude>.editorconfig</exclude>
-
<exclude>**/.settings/**/*</exclude> <!-- Eclipse -->
-
<exclude>**/.classpath</exclude> <!-- Eclipse -->
-
<exclude>**/.project</exclude> <!-- Eclipse -->
-
<exclude>**/.idea</exclude> <!-- IntelliJ -->
-
<exclude>**/.rat-excludes</exclude>
+ <exclude>**/*.mapping</exclude>
+ <exclude>**/*.flux</exclude>
+ <exclude>**/*.txt</exclude>
+ <exclude>**/*.rss</exclude>
+ <exclude>**/*.tar.gz</exclude>
+ <exclude>**/README.md</exclude>
+ <exclude>**/target/**</exclude>
+ <exclude>**/warc.inputs</exclude>
+ <exclude>LICENSE</exclude>
+ <exclude>NOTICE</exclude>
+ <exclude>DISCLAIMER</exclude>
+ <exclude>CONTRIBUTING.md</exclude>
+ <exclude>RELEASING.md</exclude>
+ <exclude>THIRD-PARTY.properties</exclude>
+ <exclude>THIRD-PARTY.txt</exclude>
+ <exclude>.github/*.md</exclude>
+ <exclude>.mvn/*.config</exclude>
+ <exclude>.gitattributes</exclude>
+
<exclude>**/dependency-reduced-pom.xml</exclude>
+ <exclude>.editorconfig</exclude>
+ <exclude>**/.settings/**/*</exclude> <!--
Eclipse -->
+ <exclude>**/.classpath</exclude> <!-- Eclipse
-->
+ <exclude>**/.project</exclude> <!-- Eclipse -->
+ <exclude>**/.idea</exclude> <!-- IntelliJ -->
+ <exclude>**/.rat-excludes</exclude>
Review Comment:
@Brijeshthummar02 The rat check is still failing...
You have to add the `<exclude>.github/ISSUE_TEMPLATE/*.yml</exclude>` back.
You can also remove `<exclude>**/.rat-excludes</exclude>` now.
Friendly reminder: I think it's a good practice to run the following locally
before pushing:
```
mvn clean -B --no-transfer-progress -Prat -DskipTests verify
-Dskip.format.code=false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
