mvolikas opened a new pull request, #1488: URL: https://github.com/apache/incubator-stormcrawler/pull/1488
#621 Support for async queries and batched updates. Some notes: - For the Spout, a similar approach to OpenSearch was taken: A separate method handleSuccess processes the response when the async future completes. - http2 clients were used in all cases. - For Solr Cloud, using the async client is convoluted and probably against the architecture of CloudSolrClient, but it was the best I could think of. Adding a test seems complicated, so I'll resort to manual testing for now. - Performance wise, I did not notice major improvements, since the ConcurrentUpdateClient was already in use before and the gains of requestAsync were not major when running locally with limited resources. Pending tasks: - [ ] Test async method for CloudSolrClient - [ ] Create a scenario that highlights the performance improvements of requestAsync. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
