mvolikas commented on code in PR #1452:
URL: 
https://github.com/apache/incubator-stormcrawler/pull/1452#discussion_r1938444745


##########
external/solr/src/test/java/org/apache/stormcrawler/solr/persistence/SolrContainerTest.java:
##########
@@ -86,7 +86,7 @@ protected Container.ExecResult createCollection(String 
collectionName, int shard
                 collectionName,
                 "-n",
                 collectionName,
-                "-s",
+                "-sh",

Review Comment:
   Solr 9.8 introduced this change that broke the tests. [9.8 shard 
param](https://solr.apache.org/guide/solr/latest/deployment-guide/solr-control-script-reference.html#create-collection-or-core-parameters)
 vs [9.7 shard 
param](https://solr.apache.org/guide/solr/9_7/deployment-guide/solr-control-script-reference.html#create-core-or-collection-parameters).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to