rzo1 commented on code in PR #1444:
URL:
https://github.com/apache/incubator-stormcrawler/pull/1444#discussion_r1892548092
##########
core/pom.xml:
##########
@@ -116,22 +116,6 @@ under the License.
<groupId>org.apache.storm</groupId>
<artifactId>storm-client</artifactId>
</dependency>
- <!-- dependency overrides for vulnerable log4j versions -->
Review Comment:
We don't have a compile dependency towards log4j, so provided should be fine
afaik. A SC topology is submitted as shade to Storm and in Storm, we have log4j
available on the (different) classpaths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
