jnioche commented on PR #1343: URL: https://github.com/apache/incubator-stormcrawler/pull/1343#issuecomment-2456389209
@mvolikas, latest comments * need to bring in change from #1390 ` storm jar target/crawler-1.0-SNAPSHOT.jar org.apache.storm.flux.Flux injection.flux --local-ttl 3600 ` needs changing to ` storm local target/crawler-1.0-SNAPSHOT.jar org.apache.storm.flux.Flux injection.flux --local-ttl 3600 ` * delete the java topology classes -> there is a discussion on whether they should be removed in the core topology but here I would advocate that we shouldn't add them in the first place. The opensearch module doesn't have them. * remove the MemorySpout from the crawl.flux, rely on the separate injection and make sure the README reflects this, like we do in the OpenSearch module Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
