jnioche commented on PR #1250: URL: https://github.com/apache/incubator-stormcrawler/pull/1250#issuecomment-2453460189
> My gut reaction is that adding even more shared state to the classes is not a good way to go. > > The more I look at this the more I think there is a major design flaw. The HttpProtocol classes should not be reused for HTTP calls that have different configs. There should be separate HttpProtocol class instances created for each different config. In #1247, there are 2 proxies described, HTTP calls for those 2 proxies should not be made with the same HTTPProtocol instance. I like this approach. We already have the ability to have more than 1 instance of each protocol, ideally we would be able to configure them differently -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
