mvolikas commented on code in PR #1242:
URL:
https://github.com/apache/incubator-stormcrawler/pull/1242#discussion_r1650032704
##########
external/solr/src/main/java/org/apache/stormcrawler/solr/persistence/StatusUpdaterBolt.java:
##########
@@ -83,6 +126,23 @@ public void store(
doc.setField(String.format(Locale.ROOT, "%s.%s", mdPrefix, key),
values);
}
+ String partitionKey = partitioner.getPartition(url, metadata);
+ if (partitionKey == null) {
+ partitionKey = "_DEFAULT_";
+ }
+
+ // store routing key in metadata?
+ if (StringUtils.isNotBlank(fieldNameForRoutingKey) &&
routingFieldNameInMetadata) {
Review Comment:
Yes, i will change this. I followed the logic from opensearch
StatusUpdaterBolt that does this check inside `store()` but I guess this
improvement can also be applied there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
