rzo1 commented on code in PR #1240: URL: https://github.com/apache/incubator-stormcrawler/pull/1240#discussion_r1615559042
########## external/solr/src/test/java/org/apache/stormcrawler/solr/persistence/IndexerBoltTest.java: ########## @@ -0,0 +1,113 @@ +package org.apache.stormcrawler.solr.persistence; + +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import java.util.concurrent.*; Review Comment: Can we avoid * imports? ########## external/solr/src/test/resources/cores/docs/conf/solrconfig.xml: ########## @@ -0,0 +1,20 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<config> Review Comment: Header ########## external/solr/src/test/resources/cores/docs/conf/schema.xml: ########## @@ -0,0 +1,35 @@ +<?xml version="1.0" encoding="UTF-8" ?> Review Comment: Requires a license header. You can just run with the `rat` profile locally, so you see all the complains ;-) ########## external/solr/src/test/resources/cores/docs/core.properties: ########## @@ -0,0 +1,6 @@ +#Written by CorePropertiesLocator Review Comment: Header ########## external/solr/src/test/java/org/apache/stormcrawler/solr/persistence/IndexerBoltTest.java: ########## @@ -0,0 +1,113 @@ +package org.apache.stormcrawler.solr.persistence; Review Comment: Requires a license header ########## external/solr/src/test/resources/cores/solr.xml: ########## @@ -0,0 +1,2 @@ +<?xml version="1.0" encoding="UTF-8" standalone="yes"?> Review Comment: Header ########## external/solr/src/test/resources/cores/status/core.properties: ########## @@ -0,0 +1,6 @@ +#Written by CorePropertiesLocator Review Comment: Header ########## external/solr/src/test/java/org/apache/stormcrawler/solr/persistence/IndexerBoltTest.java: ########## @@ -0,0 +1,113 @@ +package org.apache.stormcrawler.solr.persistence; + +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import java.util.concurrent.*; +import org.apache.storm.task.OutputCollector; +import org.apache.storm.tuple.Tuple; +import org.apache.stormcrawler.Metadata; +import org.apache.stormcrawler.TestOutputCollector; +import org.apache.stormcrawler.TestUtil; +import org.apache.stormcrawler.indexing.AbstractIndexerBolt; +import org.apache.stormcrawler.solr.bolt.IndexerBolt; +import org.junit.*; Review Comment: Can we avoid * imports? ########## external/solr/src/test/resources/cores/metrics/core.properties: ########## @@ -0,0 +1,6 @@ +#Written by CorePropertiesLocator Review Comment: Header ########## external/solr/src/test/resources/cores/metrics/conf/schema.xml: ########## @@ -0,0 +1,19 @@ +<?xml version="1.0" encoding="UTF-8" ?> Review Comment: Header ########## external/solr/src/test/resources/cores/metrics/conf/solrconfig.xml: ########## @@ -0,0 +1,33 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<config> Review Comment: Header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
