maugly24 commented on pull request #92: URL: https://github.com/apache/sqoop/pull/92#issuecomment-799995775
Hi hong , I've reviewed your changes (both Github and issues.apache.org), but TBH in the current state I'm concerned both about the intention of the change, and the correctness as well. First of all: Could you please provide a bit more detail around what performance gain do you expect from this change and how did you measure it? Could you please provide also some automated testcase which would show the effect of this gain, and would ensure we don't loose it in the future? On the front of correctness: SQOOP-3149 introduced the line you'd like to remove, and if I do remember correctly absolutely intentionally. Because of this reason: Could you please provide automated test cases which ensures that SQOOP-3149 changes won't be undone by your change (so we keep the current correctness around NULL column updates)? Many thanks in advance, Attila Szabo ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
