ebogi commented on a change in pull request #80: SQOOP-3438 Sqoop Import with
create hcatalog table for ORC will not w…
URL: https://github.com/apache/sqoop/pull/80#discussion_r282789992
##########
File path: src/test/org/apache/sqoop/hcat/HCatalogImportTest.java
##########
@@ -770,6 +770,29 @@ public void testTableCreation() throws Exception {
null, true, false);
}
+ @Test
+ public void testExternalTableCreation() throws Exception {
Review comment:
Could you please add more test cases? E.g. for when the table already exists
and either exception is thrown or we drop it based on the usage of
--drop-and-create-hcatalog-table option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
