Hi, Can you please link the review in the Jira? (Or at least on this thread?)
Thanks, Fero On Fri, Sep 14, 2018 at 8:39 AM, CharSyam <chars...@gmail.com> wrote: > Thanks Fero. I created review in ReviewBoard. > > 2018년 9월 14일 (금) 오후 8:34, Fero Szabo <f...@cloudera.com.invalid>님이 작성: > > > Hi, > > > > Thank you for your contribution! > > > > Since the Sqoop community is using ReviewBoard for reviews, the next step > > would be to create a review there. > > > > This is how I explained this process on another Jira: > > Please go to Review Board at https://reviews.apache.org/account/login/ > and > > register if you haven't done so far. Then, create a patch by invoking > *git > > diff > SQOOP-2949 > > <https://issues.apache.org/jira/browse/SQOOP-2949>-1.patch on the > command > > line. Finally, create a review using the sqoop-trunk* repository and your > > patch. Fill in the necessary fields, as for example, in this review: > > https://reviews.apache.org/r/65607/ (no need for a description this > long, > > nobody likes to read this much ). > > > > After your patch has been reviewed, hopefully, a committer or PMC will > pick > > it up and commit it. > > > > Best Regards, > > Fero > > > > > > On Fri, Sep 14, 2018 at 1:06 PM, CharSyam <chars...@gmail.com> wrote: > > > > > you can test adding --mysql-charset UTF-8 options in commandline > > > > > > 2018년 9월 14일 (금) 오후 8:05, CharSyam <chars...@gmail.com>님이 작성: > > > > > > > Hi, I made a patch for sqoop-2639 > > > > actually this is for 1.4.6 branch, I also made for trunk branch. > > > > > > > > How I can upload this patch or get review? > > > > > > > > Thanks. all > > > > > > > > > > > > > > > -- > > *Ferenc Szabo* | Software Engineer > > t. (+361) 701 1201 <+361+701+1201> > > cloudera.com <https://www.cloudera.com> > > > > [image: Cloudera] <https://www.cloudera.com/> > > > > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: > Cloudera > > on LinkedIn] <https://www.linkedin.com/company/cloudera> > > ------------------------------ > > > -- *Ferenc Szabo* | Software Engineer t. (+361) 701 1201 <+361+701+1201> cloudera.com <https://www.cloudera.com> [image: Cloudera] <https://www.cloudera.com/> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> ------------------------------
