-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68677/
-----------------------------------------------------------

(Updated Sept. 11, 2018, 4:34 p.m.)


Review request for Sqoop, daniel voros, Fero Szabo, and Szabolcs Vasas.


Changes
-------

Disable FileSystem's static cache for S3 tests


Bugs: SQOOP-3383
    https://issues.apache.org/jira/browse/SQOOP-3383


Repository: sqoop-trunk


Description
-------

In the current S3 test suite the setup phase includes a logic which sets the 
AWS credentials in the Hadoop configuration in the 
org.apache.sqoop.testutil.S3TestUtils#setS3CredentialsInHadoopConf method. 
These credentials then are set via system properties calling the 
org.apache.sqoop.testutil.S3TestUtils#getArgumentArrayBuilderForS3UnitTests 
method too.

This is an unnecessary duplication that should be cleaned up to ease further 
test implementation.


Diffs (updated)
-----

  src/test/org/apache/sqoop/testutil/S3TestUtils.java 
7724026b0bad25a31aa76c89135a51538b46bf82 


Diff: https://reviews.apache.org/r/68677/diff/2/

Changes: https://reviews.apache.org/r/68677/diff/1-2/


Testing (updated)
-------

./gradlew test -Ds3.bucket.url=<bucket-url> 
-Ds3.generator.command=<credential-generator-command>


Thanks,

Boglarka Egyed

Reply via email to