----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68316/#review207314 -----------------------------------------------------------
Fix it, then Ship it! Hi Nguyen, Thank you for adding the new test case, this is exactly what I was thinking of. I have left some minor formatting findings please fix those and we can commit it. Thanks, Szabolcs src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java Line 43 (original) <https://reviews.apache.org/r/68316/#comment290660> Please remove this whitespace change. src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java Line 40 (original), 40 (patched) <https://reviews.apache.org/r/68316/#comment290661> Please remove this whitespace change. src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java Lines 1 (patched) <https://reviews.apache.org/r/68316/#comment290662> Please add the license header to this new file. src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java Lines 15 (patched) <https://reviews.apache.org/r/68316/#comment290663> This field can be private too. src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java Lines 78 (patched) <https://reviews.apache.org/r/68316/#comment290667> Please fix the camel casing of the method name: testGetDebugDetails(). src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java Lines 79 (patched) <https://reviews.apache.org/r/68316/#comment290664> According to the assertEquals definition the first parameter should be expected result. src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java Lines 82 (patched) <https://reviews.apache.org/r/68316/#comment290669> Please fix the camel casing of the method name: testEmptySplitDebugDetails(). src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java Lines 83 (patched) <https://reviews.apache.org/r/68316/#comment290665> According to the assertEquals definition the first parameter should be expected result. - Szabolcs Vasas On Aug. 14, 2018, 12:53 p.m., Nguyen Truong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68316/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2018, 12:53 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3362 > https://issues.apache.org/jira/browse/SQOOP-3362 > > > Repository: sqoop-trunk > > > Description > ------- > > The method was currently returning the hash of data chunk object. I > implemented the toString() methods inside the subclasses of > OraOopOracleDataChunk. > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java 948bdbb73 > src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java > eb67fd2e4 > src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java > 20b39eea0 > > src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java > 59889b82b > > src/test/org/apache/sqoop/manager/oracle/TestOraOopDBInputSplitGetDebugDetails.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68316/diff/3/ > > > Testing > ------- > > No test case is added because the change has already covered. > > > Thanks, > > Nguyen Truong > >
