----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68000/#review206281 -----------------------------------------------------------
Ship it! Lgtm! My 50cents: Seems like, in the long term we might end up refactoring this class to the factory pattern. Cheers, Fero - Fero Szabo On July 20, 2018, 1:47 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68000/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 1:47 p.m.) > > > Review request for Sqoop, daniel voros, Fero Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-3347 > https://issues.apache.org/jira/browse/SQOOP-3347 > > > Repository: sqoop-trunk > > > Description > ------- > > Extracting decimal conversion logic from verify() method of AvroTestUtils > class. > > > Diffs > ----- > > src/test/org/apache/sqoop/importjob/avro/AvroImportForNumericTypesTest.java > e04caf7c7c1fba24a47858c609a00ecac9f71cc5 > src/test/org/apache/sqoop/manager/hsqldb/TestHsqldbAvroPadding.java > 7e42bf1e3242acc26ae196986daa96a9160196ed > src/test/org/apache/sqoop/testutil/AvroTestUtils.java > 75940bf1fe77ba4655d88c3c0f415c548201daf9 > > > Diff: https://reviews.apache.org/r/68000/diff/1/ > > > Testing > ------- > > Ran unit and 3rd party tests successfully. > > > Thanks, > > Boglarka Egyed > >
