[ https://issues.apache.org/jira/browse/SQOOP-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490248#comment-16490248 ]
ASF GitHub Bot commented on SQOOP-3224: --------------------------------------- GitHub user christeoh opened a pull request: https://github.com/apache/sqoop/pull/46 SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer Added --as-binaryfile and --buffersize for FTP binary mode transfers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/christeoh/sqoop 3224-4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sqoop/pull/46.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #46 ---- commit b5cadeebb6f05df29c6018b391e5965a2caecbdb Author: Chris Teoh <cteoh@...> Date: 2018-05-23T06:00:43Z Fixed merge conflict commit c0de096f9dcb3109b1e8200e9494ee19c4bf203f Author: Chris Teoh <cteoh@...> Date: 2018-05-23T06:01:50Z Refactored com.cloudera namespace to org.apache.sqoop commit 49108cdf6185ad1881a857911351d4cc81fd34dd Author: Chris Teoh <cteoh@...> Date: 2018-05-23T07:03:33Z Added --as-binary flag commit cce81e53b82eb95ac5946d6092ece7178e281726 Author: Chris Teoh <cteoh@...> Date: 2017-11-15T02:36:07Z Moved mainframe FTP transfermode default setting to initDefaults() commit 19cb4a11051f7bc094ff13f54f0ecb47a91677cd Author: Chris Teoh <cteoh@...> Date: 2017-11-15T02:38:02Z Replaced import java.io.* with single class imports commit ad54c7caf205ec510feac0708ff130cce3d8970e Author: Chris Teoh <cteoh@...> Date: 2017-11-16T02:07:07Z Removed excessive logging per record to improve performance commit e48820ea21598b44630e4331be4ee04bb2842d5e Author: Chris Teoh <cteoh@...> Date: 2017-11-16T02:07:42Z Added comment to document why we need to add custom class for binary transfers commit 288412b7db4d731506b97eb2be2229ba1bcad639 Author: Chris Teoh <cteoh@...> Date: 2017-11-16T03:27:48Z Converted to use BufferedInputStream instead of InputStream commit e4a1f3a5a4a6f1fcc562b26eeda109d773b854e1 Author: Chris Teoh <cteoh@...> Date: 2017-11-17T00:57:48Z Added unit tests for MainframeDatasetFTPRecordReader.getNextBinaryRecord commit 290d5895b37ef9ca515d14e7e5d4d13730684e15 Author: Chris Teoh <cteoh@...> Date: 2017-11-17T01:19:04Z Updated unit tests and used helper classes commit 51e6d75767e56d481467d6d6c7de0bf0c76fba1d Author: Chris Teoh <cteoh@...> Date: 2017-11-17T01:22:06Z Updated unit tests to use a method of org.junit.Assert commit 8e5ea6f8d993a4c479ac20e87f5b4b7cf2e9c8df Author: Chris Teoh <cteoh@...> Date: 2017-11-17T01:35:04Z Updated unit test for compilation commit c737ea28e57c517d8f28a81802978e11e768ec3b Author: Chris Teoh <cteoh@...> Date: 2017-11-17T05:28:57Z Used StringUtils to do comparisons and corrected bulk imports commit 48602eb6e5d70ca86456a30862e583ad82e863e0 Author: Chris Teoh <cteoh@...> Date: 2017-11-28T03:51:07Z Replaced star import with specific class import commit e81b400ec2dc4c47d46d1db198ab665c0a85de3c Author: Chris Teoh <cteoh@...> Date: 2017-11-28T03:51:33Z Updated to use current class instead of deprecated class commit 3fd76409108184eace1ae1b60cad0d739af474bd Author: Chris Teoh <cteoh@...> Date: 2017-11-28T03:52:10Z Refactored common functionality to another function commit c50bd2183717f3b2a393c92711ef19fdab4dbbd2 Author: Chris Teoh <cteoh@...> Date: 2017-11-28T03:52:30Z Adjusted comment commit 6a66f3e88e7150d0dceba2a6accf120ea4498199 Author: Chris Teoh <cteoh@...> Date: 2017-11-29T04:36:44Z Moved tests from TestMainframeDatasetFTPRecordReader to separate class commit c3f1de55bd2dabc1efcdf798cd31c6d981e23c0f Author: Chris Teoh <cteoh@...> Date: 2017-11-29T04:37:15Z Adjusted class for unit test support: commit bd487e9804fd58188f2a48ec5db504a678e7bf8c Author: Chris Teoh <cteoh@...> Date: 2017-11-29T04:38:43Z Adjusted exceptions to print full stack commit 81416f08ae11f67854be89d2abc6a652fd28c3f8 Author: Chris Teoh <cteoh@...> Date: 2017-11-29T04:39:05Z Moved unit tests to another class commit 40e77151d65d8f8b3cd9dd983283ef7f53fad73e Author: Chris Teoh <cteoh@...> Date: 2017-11-29T06:17:48Z Updated unit tests commit 2ad7205ad1272b3b5965b8918a2ba69672d8c8d2 Author: Chris Teoh <cteoh@...> Date: 2017-11-29T11:27:58Z Tidied up unit tests commit bc7c43338d21eaa67ea5d92ef4a1fff8efd5783f Author: Chris Teoh <cteoh@...> Date: 2017-11-29T11:43:28Z Updated getNextBinaryRecord logic to be simpler commit eed86f87a904697098ccac952efab9ecbd98db84 Author: Chris Teoh <cteoh@...> Date: 2017-12-12T22:42:54Z Added license information commit ed7c2d5ed8ee7a2631a453c87a40cdf3a8d194cc Author: Chris Teoh <cteoh@...> Date: 2017-12-12T22:57:47Z Refactored BinaryKeyOutputFormat to RawKeyTextOutputFormat commit 5f032726a36cff473c4456596876a79c8139b187 Author: Chris Teoh <cteoh@...> Date: 2017-12-12T22:58:56Z Added license information commit 4bbd746a2500619bfe6ccc7fc860664e1635f9e9 Author: Chris Teoh <cteoh@...> Date: 2017-12-12T23:02:09Z Added license information commit 0c4b022d409ca5a27d2b268d46614fd0c7ed78a9 Author: Chris Teoh <cteoh@...> Date: 2017-12-12T23:09:01Z Added license information commit a098c2af879da0650365bd28a03d0f5abfefdaeb Author: Chris Teoh <cteoh@...> Date: 2017-10-25T10:20:07Z Added support for binary ftp transfers ---- > Mainframe FTP transfer should have an option to use binary mode for transfer > ---------------------------------------------------------------------------- > > Key: SQOOP-3224 > URL: https://issues.apache.org/jira/browse/SQOOP-3224 > Project: Sqoop > Issue Type: Improvement > Reporter: Chris Teoh > Assignee: Chris Teoh > Priority: Minor > > Currently the mainframe FTP module is hard coded to use ascii transfer mode. > Propose a mainframe module flag to be able to change modes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)